Review "Islamic date/time functions" version 2

Review of "Islamic date/time functions" version 2

Details Page Preview

Islamic date/time functions

by aelmahmoudy

Add Hijri date & prayer times to date menu

Extension Homepage: https://github.com/aelmahmoudy/gnome-shell-extension-islamic-datetime

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version	Status
20	Active
19	Active
18	Active
17	Active
16	Active
15	Active
14	Active
13	Rejected
12	Active
11	Rejected
10	Rejected
9	Rejected
8	Rejected
7	Rejected
6	Active
5	Active
4	Inactive
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

gcampax posted a review May 20, 2012

You're still targetting 3.2, and as magcius said, this is not allowed when using GSettings (using Gio.SettingSchemaSource would simply fail there, because it was added in a newer libgio). Also, you may want to check https://extensions.gnome.org/extension/240/persian-calendar/ . I don't know if it's actually the same, but is has code to show the date in the traditional format.