Review of "Islamic date/time functions" version 4

Details Page Preview

Add Hijri date & prayer times to date menu

Extension Homepage
https://github.com/aelmahmoudy/gnome-shell-extension-islamic-datetime

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Rejected
12 Active
11 Rejected
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Active
5 Active
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

aelmahmoudy posted a review
Targetting GNOME Shell 3.4 only
aelmahmoudy posted a review
gcampax, would you please re-approve this extension ? Seems that the failure in the database server caused some data loss (apparently including yesterday's approval)
gcampax posted a review
Ok, here you are (there was a rationale in the previous approval, but I'm lazy)
aelmahmoudy posted a review
Your previous preview was: "Well, after all there is nothing against this, so approving."
aelmahmoudy posted a review
Yet, there is a problem, that the schema file doesn't seem to get installed ! ie. it is in the extension directory, but the extension isn't supposed to read it from there. How do I get the schema file to get installed in a proper path ?
gcampax posted a review
Uh right, you need to ship the "gschema.compiled" file in the zip file. You should generate it as part of the build system (the @GSETTINGS_RULES@ you include in Makefile.am already handle it) and then copy it in the right place. (See http://git.gnome.org/browse/gnome-shell-extensions/tree/Makefile.am for some Makefile magic to do that with a autotools system)
aelmahmoudy posted a review
Thanks