GNOME Shell Extensions

Review of "Islamic date/time functions" version 18

Details Page Preview

Islamic date/time functions

by aelmahmoudy

Add Hijri date & prayer times to date menu

Extension Homepage
https://github.com/aelmahmoudy/gnome-shell-extension-islamic-datetime
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Rejected
12 Active
11 Rejected
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Active
5 Active
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

aelmahmoudy posted a review
* For some reason GNOME Shell 3.8 (or is it GJS 3.6) doesn't accept Date.new_dmy as a constructor ! Hence use default constructor followed by set_dmy() call. * Use simpler method (Util.spawn) to launch extension preferences. Hence making it work again.
gcampax active
It's not "new GLib.Date.new_dmy()", it's a bare GLib.Date.new_dmy() call. Also, you should use GLib.DateTime or JS Date, not GLib.Date.
aelmahmoudy posted a review
Itl.Prayer.getPrayerTimes & Itl.Prayer.getNextDayFajr methods from libitl-gobject expect gDate not gDateTime objects