Review of "Show Desktop Button" version 1

Details Page Preview

Places a button to the left(default) of the App Menu to hide all windows, and the Overview if active, and show the current desktop. Panel location can be changed via prefs. The visible icon changes when you have toggled hiding/showing of the desktop. Can now be controlled via space/keyboard as well, when hovered, this can be achieved with ctrl/alt/tab/panel/arrows/space or enter. Eventually actual keybinding will happen(v22??). *icon credit madkristoff(thanks, this is _still_ the only icon created and submitted!)* (credit:madkristoff, jonnius, mbokil, simonthechipmunk, MGSE, erguille, mikechaberski, mathematicalcoffee, asan, spinus, Xes, gcampax, magcius). v21: cleanup v20 store toggle mode when panel location changed remove st.bin fix settings leak this is stable now! v20 Huge release lots of cleanup, now works with space or enter when hovered, also restores focus to last focused window. v19 localized thanks to jonnius, icon now toggles modes to indicate status of windows. v18 stylesheet removed, now uses system style, more cleanup & notations. v17 placement option returns, left right or center only for now. todo: icon setting, keybinding, better pleacement

Extension Homepage
https://github.com/l300lvl/Show-Desktop-Button

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
21 Active
20 Rejected
19 Inactive
18 Active
17 Active
16 Active
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Active
9 Active
8 Inactive
7 Active
6 Rejected
5 Inactive
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

gcampax posted a review
1) You're creating objects and connecting signals inside init(). This means that having the extension installed but disabled won't work. 2) You're not installing any gettext file for the gnome-shell-extensions domain (that you don't control, btw), so please remove that line. 3) You're not paring the property sets in enable() with deletes in disable() 4) Your window list is not destroyable (does not disconnect signals from the window tracker properly)
l300lvl posted a review
1) Does that mean it can't be disabled? I can disable it from here with no problems. 2) Understood. This is removed and I will update. 3) Example? 4) It's not a Window List, I am working on removing all of the window list code, the extension was created by Linux Mint in their MGSE package as a Windows List which includes the show Desktop button. I am only modifying the code as much as possible to have a functioning Show Desktop button, separate from the Windows List, I don't even use their Windows List. This is an amateurs first time attempt and I have no experience. Do you have any suggested reading or ideas? Perhaps you can lend a hand or take this on as your own? It's mostly just proof of concept I guess. /shrugs
l300lvl posted a review
I have updated and am submitting version 2 now.
gcampax posted a review
Rejecting as there is a newer version.