Review "Quick Close in Overview" version 2

Review of "Quick Close in Overview" version 2

Details Page Preview

Quick Close in Overview

by gtsiam

Close windows with a button click (the middle one by default) when in overview mode

Extension Homepage: https://github.com/p91paul/middleclickclose

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
31	Active
30	Active
29	Active
28	Active
27	Active
26	Active
25	Active
24	Rejected
23	Active
22	Active
21	Rejected
20	Active
19	Rejected
18	Inactive
17	Active
16	Active
15	Active
14	Active
13	Active
12	Active
11	Active
10	Active
9	Rejected
8	Active
7	Active
6	Active
5	Active
4	Rejected
3	Active
2	Active
1	Active

Previous Reviews on this Version

gcampax active August 31, 2012

Instead of adding custom properties to the prototypes, you can save the regular version of the functions you need as a local variable, and then use call or apply. E.g. <global scope> let regularOnClikced; function enable() { regularOnClicked = Workspace.WindowClone.prototype._onClicked; } function myOnClick() { regularOnClicked.apply(this, arguments); ... } Still, the way you write it is not a problem.

redsun82 posted a review August 31, 2012

thanks, I'll follow your suggestion! I'll add a new feature shortly (I hope), so I'll roll in the change then.