Review of "Color Picker" version 5

Details Page Preview

Simple color picker for GNOME Shell For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/color-picker

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

andyholmes active
Looks like you have a typo in your template string at extension.js#319 If you run `journalctl -f -o cat /usr/bin-gnome-shell` in a terminal you can see there are several assertions being printed, probably as a result of one of your event vfunc's. Probably best to avoid `Gdk.Display.warp_pointer()` and instead look into `Clutter.VirtualDevice` (https://gjs-docs.gnome.org/clutter6-virtualinputdevice/) which should also work on Wayland. I believe there's some use of that in GNOME Shell you could reference. Still needs some polish, but nothing bad enough to reject, keep up the good work :)
grroot posted a review
Thanks! ;) I will fix those soon.