Review of "The Circles - Desktop Widget" version 1

Details Page Preview

Show System Infomations on Desktop as Circles Desktop Widget more info https://www.linuxuprising.com/2020/11/display-clock-ram-and-cpu-usage-as.html

Extension Homepage
https://github.com/xenlism/showtime

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Active
10 Active
9 Rejected
8 Rejected
7 Rejected
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

andyholmes rejected
Please see https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review for notes on what reviewers looks for. In particular you are connecting signals in `init()` which is not allowed. You are also using tweener without importing it (`imports.tweener.tweener`). Please fix these problems so your extension can be approved. Additionally: * Any time you draw to a Cairo context, you must call `$dispose()` before returning from the function, or you will leak memory (eg. `ctx.$dispose()`) * In your external processes, you are running two main loops: one explicit `GLib.MainLoop` and the second started by `Gtk.main()`. You should only use the second in a Gtk application. * It would be much better to draw your graphics in gnome-shell rather than spawning numerous headless processes and then calling `pkill` to end them * If you still decide to do so, you should using Gio.Subprocess to spawn and track your processes
xenatt posted a review
I will solve this problem.
xenatt posted a review
1. I fixed imports.tweener.tweener 2. I fixed`GLib.MainLoop` and `Gtk.main()` I cant draw graphics in gnome-shell because gnome-shell dont support desktop windows or widget. I need more infomation about ctx.$dispose() and Gio.Subprocess I find solution for end process after disable extension or restart shell. please tell me for more information thank in advance ixenatt@gmail.com
andyholmes posted a review
> I cant draw graphics in gnome-shell because gnome-shell dont support desktop windows or widget. GNOME Shell supports both, via the Clutter (https://gjs-docs.gnome.org/#q=clutter), St (https://gjs-docs.gnome.org/#q=st) and Meta (https://gjs-docs.gnome.org/#q=meta) libraries. StDrawingArea is a good choice for drawing custom widgets with Cairo. > I need more infomation about ctx.$dispose() and Gio.Subprocess Cairo.Context.$dispose() is a functional particular to GJS that frees allocated memory that is unknown to the JavaScript engine. Gio.Subprocess is a high-level API for spawning subprocesses. It is documented in the Gio API docs and there is an overview here: https://andyholmes.github.io/articles/subprocesses-in-gjs.html You can spawn a process using Gio.Subprocess.new() and call Gio.Subprocess.force_exit() on the returned process object.
xenatt posted a review
Can gnome Shell St do like keep it below desktop?
xenatt posted a review
I use pkill because whenever user restart shell sometime sub process ( widget process still alive not kill) pkill can kill process by process path. I try to use Gio.subprocess it work but when I restart gnome-shell , gnome-shell crash.
andyholmes posted a review
Sorry, the review infrastructure isn't the proper place for long help discussions. I'd recommend asking a question on discourse (https://discourse.gnome.org/tag/extensions) or the Extensions channel on Matrix (https://matrix.to/#/#extensions:gnome.org). I will review your latest extension.