Review of "Simple net speed" version 23

Details Page Preview

Simply showing network speed. Left click to change modes: 1. Total net speed in bits per second 2. Total net speed in Bytes per second 3. Up & down speed in bits per second 4. Up & down speed in Bytes per second 5. Total of downloaded in Bytes (Right click to reset counter) Middle click to change font size

Extension Homepage
https://github.com/biji/simplenetspeed

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection active
Thanks for fixing the issues. Approved but please fix this warnings in the next version: Some code called array.toString() on a Uint8Array instance. Previously this would have interpreted the bytes of the array as a string, but that is nonstandard. In the future this will return the bytes as comma-separated digits. For the time being, the old behavior has been preserved, but please fix your code anyway to explicitly call ByteArray.toString(array). (Note that array.toString() may have been called implicitly.) 0 toString() ["self-hosted":544:0] 1 parseStat() ["/home/ice/.local/share/gnome-shell/extensions/simplenetspeed@biji.extension/extension.js":82:19] 2 enable/timeout<() ["/home/ice/.local/share/gnome-shell/extensions/simplenetspeed@biji.extension/extension.js":228:15] To fix that you need to do this: const ByteArray = imports.byteArray; let prepare = (out instanceof Uint8Array) ? ByteArray.toString(out) : output.toString(); btw, you can also move `settings = Convenience.getSettings(PREFS_SCHEMA);` to enable() if you like. Also it is needed to use `button.destroy();` on disable() after removing it from the panel. If you you need help please ask us on GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org