Review of "Shutdown Timer" version 5

Details Page Preview

Shutdown/reboot/suspend the device after a specific time or wake with a rtc alarm. The screen-saver will not interrupt the timer. A privileged control script may be installed to control shutdown and rtcwake as user.

Extension Homepage
https://github.com/Deminder/ShutdownTimer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

dlandau waiting for author
- prefix other than /usr doesn't work (for polkit file) -> should be binary to /usr/local and policy files to /usr - remove the backup file ui/prefs.ui~ on the next version I'm willing to accept this version, but do you wan to fix the prefix footgun first?
Deminder posted a review
> prefix other than /usr doesn't work (for polkit file) I noticed that it did not work but assumed it may work on other systems I got this code from https://github.com/martin31821/cpupower/blob/master/tool/installer.sh#L87-L92 maybe this should be changed there also ? > ... do you wan to fix the prefix footgun first? Yeah, let me remove this PREFIX option entirely (and reject this version) Thank you, for your review :)
dlandau rejected
They use prefix /usr and install the bin to /usr/local