Review of "Shutdown Timer" version 20

Details Page Preview

Shutdown/reboot/suspend the device after a specific time or wake with a rtc alarm. The screen-saver will not interrupt the timer. A privileged control script may be installed to control shutdown and rtcwake as user.

Extension Homepage
https://github.com/Deminder/ShutdownTimer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
What happens to the shutdown time menu (inside aggregate menu) in unlock dialog? (since you are using `session-modes`)
Deminder posted a review
The session-mode "unlock-dialog" should allow the timer action to trigger even during unlock-dialog or screen-saver, see extension.js:360. Otherwise the extension would be disabled, meaning, shutdown timer would be canceled. Is this not the intended way to use the "unlock-dialog" session mode? Before I did it differently by only partially disabling the extension if the screen-saver is active. Btw, although it would not be necessary to see/control the shutdown timer menu during the unlock-dialog, the status menu is not even accessible during the unlock-dialog (only in the gdm dialog) on the gnome 42 system I tested.
Deminder posted a review
@JustPerfection I guess you can reject this for now since I somehow missed that it does disable the extension (killing the timer) when locking the screen even with "unlock-dialog" mode (so I probably misunderstood how this works).
JustPerfection rejected
I reject this one for now since the menu will remain in the aggregate menu in unlock dialog. I guess you can use the old way (without `session-modes`).