Review of "Bluetooth Quick Connect" version 24

Details Page Preview

This extension allows paired Bluetooth devices to be connected and disconnected via the GNOME system menu, Shows battery status and more.

Extension Homepage
https://github.com/Extensions-Valhalla/gnome-bluetooth-quick-connect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
You forgot to remove timeouts on disable. line 164 and 188 (ui.js).
bjarosze posted a review
I did it on purpose. I've checked (here: https://docs.gtk.org/glib/func.timeout_add.html) that timeout is destroyed if function returns false. I've double checked it and in my case those functions are indeed executed only once, so I guess there is no need to remove timeouts explicitly?
bjarosze posted a review
But you're right. It will throw error if extension would be disabled in the meantime. I will fix it.
JustPerfection posted a review
You should remove it on disable even if the function returns false or GLib.SOURCE_REMOVE. We want that just because of the security. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions