Review "Bluetooth Quick Connect" version 38

Review of "Bluetooth Quick Connect" version 38

Details Page Preview

Bluetooth Quick Connect

This extension allows paired Bluetooth devices to be connected and disconnected via the GNOME system menu, Shows battery status and more.

Extension Homepage: https://github.com/Extensions-Valhalla/gnome-bluetooth-quick-connect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
54	Active
53	Active
52	Active
51	Active
50	Active
49	Active
48	Active
47	Rejected
46	Active
45	Rejected
44	Rejected
43	Active
42	Active
41	Active
40	Active
39	Active
38	Rejected
37	Active
36	Active
35	Rejected
34	Active
33	Active
32	Active
31	Active
30	Active
29	Active
28	Rejected
27	Active
26	Active
25	Active
24	Rejected
23	Active
22	Active
21	Rejected
20	Active
19	Active
18	Inactive
17	Inactive
16	Active
15	Inactive
14	Rejected
13	Active
12	Inactive
11	Inactive
10	Active
9	Rejected
8	Active
7	Active
6	Inactive
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected November 7, 2023

1. You cannot create instance of objects in the constructor (line 29-32 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources Move those lines to enable and null them out in disable. 2. You can add your own copyright notice after/before the original author notice. but not remove the original author's copyright notice. https://gjs.guide/extensions/review-guidelines/review-guidelines.html#licensing 3. Timeout should be removed on disable/destroy (line 136 ui.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 4. It's better to create `destroy()` method in `PopupBluetoothDeviceMenuItem` and do this inside that: ```js destroy() { this.disconnectSignals(); super.destroy(); } ``` after that, you can remove line 214 (extension.js).