Review of "Bluetooth Quick Connect" version 38

Details Page Preview

This extension allows paired Bluetooth devices to be connected and disconnected via the GNOME system menu, Shows battery status and more.

Extension Homepage
https://github.com/Extensions-Valhalla/gnome-bluetooth-quick-connect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create instance of objects in the constructor (line 29-32 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources Move those lines to enable and null them out in disable. 2. You can add your own copyright notice after/before the original author notice. but not remove the original author's copyright notice. https://gjs.guide/extensions/review-guidelines/review-guidelines.html#licensing 3. Timeout should be removed on disable/destroy (line 136 ui.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 4. It's better to create `destroy()` method in `PopupBluetoothDeviceMenuItem` and do this inside that: ```js destroy() { this.disconnectSignals(); super.destroy(); } ``` after that, you can remove line 214 (extension.js).