Review of "Run or raise" version 15

Details Page Preview

Launch or focus the window or define custom shortcuts in a text file

Extension Homepage
https://github.com/CZ-NIC/run-or-raise

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
38 Active
37 Active
36 Rejected
35 Rejected
34 Active
33 Inactive
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Rejected
25 Active
24 Active
23 Active
22 Rejected
21 Rejected
20 Rejected
19 Rejected
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Inactive
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active
Thanks for fixing those issues. 1. I approved this one since the code was there from the older versions but throwing like that in global scope is bad (extension.js line 18). I recommend to use Main.notify('Failed') instead of throwing like that. Also do those try catch blocks should be inside a function. and then enable() can call that function and disable should null them out. You can also ask in GNOME Matrix channel about those issues you commented. Maybe you can find a solution there. 2. Instead of creating folders or files with spawn command use Gio.File: https://gjs-docs.gnome.org/gio20~2.66p/gio.file 3. Don't use spawn command for sending notification. Use Main.notify(): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/c3f5aa6c5c4d06acd89837119cbe380f092cae67/js/ui/main.js#L460 4. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (supported on 3.34 and higher): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 5. Multi versioning is supported here. You can remove those shell version checking (for example line 16 prefs.js) and have a much cleaner code. 6. You can remove "40.1" (metadata.json) since you are using "40". If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
e2rd posted a review
Thanks for all the tips and guidelines! I'll try to implement them.