Review of "Run or raise" version 20

Details Page Preview

Launch or focus the window or define custom shortcuts in a text file

Extension Homepage
https://github.com/CZ-NIC/run-or-raise

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
38 Active
37 Active
36 Rejected
35 Rejected
34 Active
33 Inactive
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Rejected
25 Active
24 Active
23 Active
22 Rejected
21 Rejected
20 Rejected
19 Rejected
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Inactive
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please read version 19 review.
e2rd posted a review
Thanks for pointing out custom metadata.json values. However, the extension does not use the `log` function for debugging, not at all. It's just for reporting the errors the user needs to know about. The user would be confused if no error would be output. For example, if user tries to handle the shortcut `<Super><Alt>Up`, it fails because this is reserved for Activities window in newer version of Ubuntu. Lucklily, in such cases, the extension writes down `Run-or-raise> Unable to grab accelerator, <Super><Alt>Up` to the log. I've read through https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging thoroughly. It states: "The log should only be used for important messages and errors." And this is true – only important errors are logged out (and always have been).
JustPerfection posted a review
Why don't you use `Main.notify()` instead? ```js const Main = imports.ui.main; Main.notify('Message Title', 'Message Body'); ```
e2rd posted a review
Ok, if you do not recommend using log for error messages, I'll re-submit with the Main.nofity.
JustPerfection posted a review
I can approve it if it's really necessary. but I mean if the end user should see the message when something goes wrong `Main.notify` is much better. Not all users think about `log` when the shortcut isn't working.
e2rd posted a review
You are right, I've been just too conservative. Thanks!