GNOME Shell Extensions

Review of "Syncthing Indicator" version 21

Details Page Preview

Syncthing Indicator

by 2nv2u

Shell indicator for starting, monitoring and controlling the Syncthing daemon using SystemD

Extension Homepage
https://github.com/2nv2u/gnome-shell-extension-syncthing-indicator
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
35 Active
34 Active
33 Active
32 Rejected
31 Active
30 Rejected
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Rejected
17 Active
16 Active
15 Rejected
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
1. Approved this one since the code was there from older versions but you need to move line 29 to enable and also do this in disable: ```js syncthingIndicator = null; syncthingManager = null; console = null; ``` https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
2nv2u posted a review
Hi, thanks for your feedback! Can you explain your first improvement a little bit more?
JustPerfection posted a review
Basically you cannot create objects in global scope. You can read the review guidelines here: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization And you should null everything out in disable to make sure they get cleaned after uninstall.