Review of "Syncthing Indicator" version 21

Details Page Preview

Shell indicator for monitoring and controlling Syncthing. Using SystemD will add the ability to (auto) start and stop the service.

Extension Homepage
https://github.com/2nv2u/gnome-shell-extension-syncthing-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection active
1. Approved this one since the code was there from older versions but you need to move line 29 to enable and also do this in disable: ```js syncthingIndicator = null; syncthingManager = null; console = null; ``` https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
2nv2u posted a review
Hi, thanks for your feedback! Can you explain your first improvement a little bit more?
JustPerfection posted a review
Basically you cannot create objects in global scope. You can read the review guidelines here: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization And you should null everything out in disable to make sure they get cleaned after uninstall.