GNOME Shell Extensions

Review of "Syncthing Indicator" version 22

Details Page Preview

Syncthing Indicator

by 2nv2u

Shell indicator for starting, monitoring and controlling the Syncthing daemon using SystemD

Extension Homepage
https://github.com/2nv2u/gnome-shell-extension-syncthing-indicator
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
35 Active
34 Active
33 Active
32 Rejected
31 Active
30 Rejected
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Rejected
17 Active
16 Active
15 Rejected
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
1. I approved this one since `logger.Service` doesn't do too much but please fix it for the next version: You are still creating object in line 32 (extension.js). You cannot create objects in global scope which is the same as init(): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. You should also null everything out in disable to make sure the properties are getting cleaned after uninstall. So do this on disable: this.manager = null; this.indicator = null;