Review of "DownFall" version 13

Details Page Preview

Moves text of your choice across the screen. Can simulate leaves, snow, fireworks, ufos, and more!

Extension Homepage
https://github.com/torculus/DownFall

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

bsosenba posted a review
I made it clearer that `FallItem.fall()` uses Clutter's `ease()` to move items across the screen. I also migrated random number generation to `GLib.random_int_range()` to prevent total GNOME lockup (aka "freezing"). Finally, I updated copy(left) year
JustPerfection rejected
1. Move line 31 (extension.js) to enable(). You cannot create objects in global scope which is the same as init(): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Also null that out in disable. 2. Use ExtensionUtils.getSettings() instead of creating your own custom function: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 3. Line 119 (extension.js) you should also remove the timeout source on disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions