Review of "DownFall" version 30

Details Page Preview

Moves text of your choice across the screen. Can simulate leaves, snow, fireworks, ufos, and more!

Extension Homepage
https://github.com/torculus/DownFall

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
Please remove line 408-410 extension.js and send it again. Btw, it would be much nicer to remove the timeouts in the same class you are creating them.
bsosenba posted a review
When you say "remove the timeouts in the same class", would that mean overriding the "destroy()" method on the FallItems? Like this: ``` class FallItem extends St.Label { ... destroy() { GLib.source_remove(myTimeout1); GLib.source_remove(myTimeout2); //etc super.destroy(); } } ```
JustPerfection posted a review
Yes.