Review of "Tiling Assistant" version 29

Details Page Preview

Expand GNOME's 2 column tiling and add a Windows-snap-assist-inspired popup...

Extension Homepage
https://github.com/Leleat/Tiling-Assistant

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection active
Good but you should null out the timeout id inside timeout callback when you return false or `GLib.SOURCE_REMOVE`. For example: ```js this._openAppTiledTimerId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 60000, () => { createId && global.display.disconnect(createId); createId = 0; firstFrameId && wActor.disconnect(firstFrameId); firstFrameId = 0; this._openAppTiledTimerId = 0; // <-- or null return GLib.SOURCE_REMOVE; }); ``` Otherwise, You will have warning in logs when you do `GLib.Source.remove(this._openAppTiledTimerId);` because the timeout id has been removed before but `this._openAppTiledTimerId` still has the timeout id. I approve this since it's just a warning. Please fix it for the next version.