Review "Server Status Indicator" version 1

Review of "Server Status Indicator" version 1

Details Page Preview

Server Status Indicator

by CraigFoote

Indicator displaying status of entered web server URLs using emojis.

Extension Homepage: https://github.com/CraigFoote/ca.footeware.gnomeshell.serverstatus.git

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
32	Active
31	Active
30	Active
29	Active
28	Rejected
27	Active
26	Active
25	Active
24	Active
23	Active
22	Active
21	Active
20	Rejected
19	Active
18	Active
17	Active
16	Active
15	Rejected
14	Rejected
13	Rejected
12	Active
11	Active
10	Rejected
9	Active
8	Active
7	Active
6	Rejected
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected December 18, 2021

1. You cannot create objects in global scope which is the same as init function: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move line 15 (extension.js) to enable. 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 3. Line 34-45 can be replaced by `ExtensionUtils.getSettings()`. 4. Also do this on disable: ```js serverIcon = null; serverUpIcon = null; serverDownIcon = null; ``` 5. Remove unnecessary log (line 25 and 68 extension.js). 6. What is the reason for using ` Mainloop.quit()` and `Mainloop.run()` instead of returning `GLib.SOURCE_CONTINUE` and `GLib.SOURCE_REMOVE`? I think it's better to use `return GLib.timeout_add(GLib.PRIORITY_DEFAULT, delay, func);` inside `setInterval()` function. And the callback can have control over the timeout. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions