Indicator displaying status of entered web server URLs using emojis.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
32 | Active |
31 | Active |
30 | Active |
29 | Active |
28 | Rejected |
27 | Active |
26 | Active |
25 | Active |
24 | Active |
23 | Active |
22 | Active |
21 | Active |
20 | Rejected |
19 | Active |
18 | Active |
17 | Active |
16 | Active |
15 | Rejected |
14 | Rejected |
13 | Rejected |
12 | Active |
11 | Active |
10 | Rejected |
9 | Active |
8 | Active |
7 | Active |
6 | Rejected |
5 | Active |
4 | Active |
3 | Active |
2 | Active |
1 | Rejected |
Please don't store any instance of objects in a property in the default class you are exporting (line 23-24 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make it local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ```
Also line 22 `prefs.js` has that issue.
Will this be sufficient? this.window = window; this.page = new Adw.PreferencesPage(); this.gioSettings = this.getSettings(); this.serverGroups = []; // destroy on close window.connect('close-request', () => { this.serverGroups = null; this.gioSettings = null; this.page = null; });
Yes.