Review of "Server Status Indicator" version 14

Details Page Preview

Indicator displaying status of entered web server URLs using emojis.

Extension Homepage
https://github.com/CraigFoote/ca.footeware.gnomeshell.serverstatus.git

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
32 Active
31 Active
30 Active
29 Active
28 Rejected
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Rejected
19 Active
18 Active
17 Active
16 Active
15 Rejected
14 Rejected
13 Rejected
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. When you use `setInterval()`, use `clearInterval()` instead of line 54 `serverStatusPanel.js`. 2. They won't get garbage collected after window close since you used `this` (line 14-16 prefs.js). Make the local inside that method. You can attach settings to the `window` in case you want to avoid garbage collecting before window close: https://gjs.guide/extensions/development/preferences.html#prefs-js
CraigFoote posted a review
1. I don't understand. Line 54 of serverStatusPanel.js is GLib.source_remove(this.intervalID); What should it be? I don't have a clearInterval method. 2. Is it ok if extension.js has some global variables?
JustPerfection posted a review
1. Missed that. Line 50 you used `this.setInterval()`. It's ok. you used `GLib.timeout_add()` inside that method. 2. Yes, only when you clean them up in disable. If you are asking that for prefs.js, you can use this to clean up in prefs.js: ```js window.connect('close-request', () => { // clean up here }); ```