Review of "Brightness control using ddcutil" version 17

Details Page Preview

Brightness control for all the monitors detected by ddcutil This tool uses ddcutil as backend for communication with your display. Read setup instructions from: https://github.com/daitj/gnome-display-brightness-ddcutil/blob/master/README.md

Extension Homepage
https://github.com/daitj/gnome-display-brightness-ddcutil

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init (indicator.js line 21): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. You should remove the timeout in destroy (indicator.js line 197): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. Your extension only supports 40 and 41. You don't need to check for `openPrefs()` (extension.js line 391). Use it directly. 5. Where do you create `settings` in extension.js? You should also null out `settings` in disable. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions