Review of "Brightness control using ddcutil" version 20

Details Page Preview

Brightness control for all the monitors detected by ddcutil This tool uses ddcutil as backend for communication with your display. Read setup instructions from: https://github.com/daitj/gnome-display-brightness-ddcutil/blob/master/README.md

Extension Homepage
https://github.com/daitj/gnome-display-brightness-ddcutil

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
Where do you call `SingleMonitorSliderAndValue.clearTimeout()` (line 191 indicator.js)? Does it happen when the extension is getting disabled?
themightydeity posted a review
In line 126 of extensions.js, all of the SingleMonitorSliderAndValue instances are stored as display.slider in line 186 if extensions.js. I hope this is correct implementation.
JustPerfection active
It's okay but it could be better to have that as `destroy()` and call `destroy()` instead of `clearTimeout()`. To give you an example: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/ab5977713b5b5dbfd0a1cec453f0a0528800dedf/js/ui/altTab.js#L283-288