Review of "ShutdownTimer" version 31

Details Page Preview

Shutdown/suspend the device after a specific time. Maximum timer value und default slider position can be modified in the settings.

Extension Homepage
https://github.com/neumann-d/ShutdownTimer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
35 Active
34 Active
33 Active
32 Rejected
31 Rejected
30 Active
29 Active
28 Rejected
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you cannot create objects in init function (extension.js line 201): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that line to enable. Also disconnect all signals on disable. 2. Also do this on disable: ```js timer = null; settings = null; ``` 3. I recommend to remove convenience.js file and use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (supported on 3.34 and higher): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Remove all .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 5. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
btw, multi versioning is supported here if you need it.