Review of "Brightness Control" version 15

Details Page Preview

A helper letting you control your display brightness. Can be set to persist across reboots. Supports hover scrolling and custom keybindings for changing brightness. The original author is lmedinas. Special thanks to dsboger, pulb, koluch and jonius! Note: Not compatible with Ubuntu 14.04. For Gnome Shell 3.10, please use the integrated control.

Extension Homepage
http://gitorious.org/gnome-shell-brightness-extension/gnome-shell-brightness-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
19 Active
18 Active
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Rejected
8 Active
7 Rejected
6 Inactive
5 Active
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

gcampax active
Of course the signal will not work under GDBus, you need a correct DBus definition, without arguments (because the signal doesn't have any). Gio automatically drops on the floor any signal which is not explicitly declared in the XML definition, or which has a wrong type.
OrestTa posted a review
What exactly do you mean? Is the XML definition wrong? What type should the changed signal have? *** <signal name="Changed"> <arg type="" direction="in" /> </signal>
gcampax posted a review
Yes, the XML definition is wrong, it should be <signal name="Changed" /> (ie, without any <arg> element)
OrestTa posted a review
thanks! (see new version)