Review of "Freon" version 46

Details Page Preview

Shows CPU temperature, disk temperature, video card temperature (NVIDIA/Catalyst/Bumblebee&NVIDIA), voltage and fan RPM (forked from xtranophilist/gnome-shell-extension-sensors)

Extension Homepage
https://github.com/UshakovVasilii/gnome-shell-extension-freon

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
57 Active
56 Active
55 Active
54 Active
53 Rejected
52 Active
51 Rejected
50 Active
49 Rejected
48 Active
47 Rejected
46 Rejected
45 Active
44 Active
43 Active
42 Active
41 Inactive
40 Active
39 Active
38 Active
37 Inactive
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Rejected
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Rejected
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
1. Please remove po folder: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. What `sudo` is doing in `freeipmiUtil.js`?
UshakovVasilii posted a review
(1) done (2) information about "sudo", it is optional: https://github.com/UshakovVasilii/gnome-shell-extension-freon/pull/220 I uploaded version 47
JustPerfection waiting for author
So you are using `sudo` for the spawn command there? you cannot use `sudo` in extensions. You should use `pkexec` instead: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#privileged-subprocess-must-not-be-user-writable
JustPerfection rejected
Newer version approved.
UshakovVasilii posted a review
Hello @JustPerfection , looks like we cannot use "pkexec": https://github.com/UshakovVasilii/gnome-shell-extension-freon/pull/220#issuecomment-1101877202 > unless I missed something I do not find any pkexec equivalence to sudo's --non-interactive option. This option is required to silently fail if the user have not configured any sudo permission, and we would need something equivalent to silently fail if the user have not configured any pkexec permission. > When using pkexec, if the user have not configured any permission, the user will be annoyed by a pop-up every time freon polls sensors, which does not sound acceptable. > It looks like pkexec is tailored for another need: the need for prompting a permission. > > Here the code I wrote is meant to never prompt a permission, ever, and to avoid prompting a permission at all cost, failing to fetch data is preferred over prompting user on every poll.
JustPerfection posted a review
Is udev rules an option?