Review of "Window Is Ready - Notification Remover" version 15

Details Page Preview

Removes window is ready Notification

Extension Homepage
https://github.com/nunofarruca/WindowIsReady_Remover

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Rejected
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Rejected
14 Inactive
13 Active
12 Active
11 Rejected
10 Active
9 Inactive
8 Active
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. You shouldn't use `disconnectObject` for objects you don't own. You can find signal id and disconnect instead: https://gjs.guide/extensions/upgrading/gnome-shell-42.html#finding-signal-id You can also see how I'm doing it: https://gitlab.gnome.org/jrahmatzadeh/just-perfection/-/blob/74b4619dbda98311597b59e6b1d9eccd073fcffc/src/lib/API.js#L1975-2025 2. Log should be only available in debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions