Review of "Window Is Ready - Notification Remover" version 16

Details Page Preview

Removes window is ready Notification

Extension Homepage
https://github.com/nunofarruca/WindowIsReady_Remover

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Rejected
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Rejected
14 Inactive
13 Active
12 Active
11 Rejected
10 Active
9 Inactive
8 Active
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

nunofarruca posted a review
Keeping only one log message when the user tries to disable extension and persistence is activated Possibly may review this at a latter stage maybe adding a notification
JustPerfection rejected
1. Why are you using `this` when you call `blockSignal` and `unblockSignal`? 2. Line 41 is unacceptable here because the extension can remain enable after disable. There are two questions need to be answered: - Why do you need to stop disabling extension in lock screen? - Why you don't check whether it is in lock screen && `prevent-disable` is `true`?
nunofarruca posted a review
1. Can be removed, if creates any issue 2. On a previous version of gnome, disable is being called on lockscreen and enable is not being called after when the screen is unlocked (think that was due to a bug or one of the methods not working properly). Only information I have is the ticket that was open https://github.com/nunofarruca/WindowIsReady_Remover/issues/12 - Can you provide me some guidance on how to check if the disable() is called from the lockscreen ? found this, is the proper way of checking: let lockingScreen = (Main.sessionMode.currentMode == "unlock-dialog" || Main.sessionMode.currentMode == "lock-screen");
JustPerfection posted a review
1. No issue but creates confusion since you are not inside class. 2. In all GNOME versions, the enabled extension will be disabled in lock screen and will be enabled after unlock. You have some options and in all of those options prefs isn't needed (should be removed). We have session modes in 42 (not supported in older versions): https://gjs.guide/extensions/upgrading/gnome-shell-42.html#metadata-json Example: https://gjs.guide/extensions/topics/session-modes.html#example-usage You can also check the session mode in disable (supported in all shell versions): ```js if (Main.sessionMode.isLocked) { return; } ```