Review of "Window Is Ready - Notification Remover" version 17

Details Page Preview

Removes window is ready Notification

Extension Homepage
https://github.com/nunofarruca/WindowIsReady_Remover

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Rejected
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Rejected
14 Inactive
13 Active
12 Active
11 Rejected
10 Active
9 Inactive
8 Active
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection waiting for author
Why don't you do this in disable instead? ```js function disable() { if {Main.sessionMode.isLocked} { return; } if (major >= 42) { unblockSignal('window-demands-attention'); unblockSignal('window-marked-urgent'); } else { enableSignalsPre42(); } } ``` so you can remove prefs.
nunofarruca posted a review
good point, will do that
JustPerfection rejected
OK, send the next one.
JustPerfection posted a review
Don't forget to also remove these files: - prefs.js - schemas/gschemas.compiled - schemas/org.gnome.shell.extensions.windowIsReady_Remover.gschema.xml` and remove line 11-23 (extension.js)