Review of "pi-hole" version 2

Details Page Preview

Status and basic controls of local Pi-Hole

Extension Homepage
https://github.com/fnxweb/gnome-shell-pi-hole

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 2. Also do this in disable: ```js PiHoleExt = null; ``` 3. Remove spawn command in line 380 extension.js. Just use `ExtensionUtils.openPrefs()`. 4. You cannot create objects in global scope (line 14, 20 prefs.js). Move line 20 to `buildPrefsWidget` and make it local. 5. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions