Review of "pi-hole" version 7

Details Page Preview

Status and basic controls of local Pi-Hole

Extension Homepage
https://github.com/fnxweb/gnome-shell-pi-hole

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection active
JustPerfection rejected
Oh! This is 44 only. So you should remove Gtk import and use `St.IconTheme`: https://gjs.guide/extensions/upgrading/gnome-shell-44.html#gtk-icontheme
fnxweb posted a review
Ah, OK ,ta
fnxweb posted a review
I cannot for the life of me how to figure out how to join the dots up, that guide stops *very* short :( I can create an St.IconTheme and append my extension's icon path fine, but I can't see how to load an icon into the St.Icon I have set up in the top bar. The only thing that didn't throw some sort of type error was sticon.set_icon_name( myname ) but that just gave me a blank icon. I feel like I needed to attach my new StIconTheme (with modified search path) to said St.Icon. I even tried to use de/seralize from Gio.ThemedIcon() but I can't create a temporary Gio.Icon to put it into (and pass to the sticon with set_gicon).