Review of "pi-hole" version 9

Details Page Preview

Status and basic controls of local Pi-Hole

Extension Homepage
https://github.com/fnxweb/gnome-shell-pi-hole

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. You cannot import `Gtk` to the GNOME Shell process (line 6 extension.js): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 2. Don't use `var`. Use `let` and `const` instead. 3. Timeout should be removed on destroy (line 247 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) Also remove the timeout right before line 247 because you are using the same property name for all other timeouts.
fnxweb posted a review
Thanks, I'll address those and resubmit when I get a mo