Review of "Transparent Window" version 8

Details Page Preview

Change the opacity of windows by compiz-style shortcut Alt+scroll. You can customize hotkey in Preference page if Alt key doesn't work.

Extension Homepage
https://github.com/pbxqdown/gnome-shell-extension-transparent-window

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Rejected
7 Active
6 Rejected
5 Rejected
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init (line 20 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Move line 45 (extension.js) to enable. 3. Also null out `keymap_timeout_id` in disable. 4. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js Supported in 3.34 and higher. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
heyheyco@gmail.com posted a review
Thanks for reviewing. For #1, shall I move all gloabl and init created object to enable function? For #4, since it is supported in 3.34 and higher, does that mean i need to drop the 3.28 support?
JustPerfection posted a review
- Yes, move those to enable and null them out in disable. - Yes. 3.28 doesn't have those functions: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/gnome-3-28/js/misc/extensionUtils.js That being said, ,multi versioning is supported here. Still, that's a recommendation.
heyheyco@gmail.com posted a review
ok i have submitted a new version