Review of "ShellTile" version 68

Details Page Preview

A tiling window extension for GNOME Shell. Just move a window to the edges of the screen to create a tiling, otherwise move a window over another one, holding down the Control key. Grouped windows minimize, resize, raise and change workspace together. Move or maximize a window to remove it from the group.

Extension Homepage
https://github.com/emasab/shelltile

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

emasab posted a review
I've removed all the signal handlers on disable (before they were kept but ignored) and they're added again on enable. Then the overview methods are replaced with the original ones (before they were kept and did pass through to the original ones) All the pending idle_add signal handlers are cancelled (they are executed only once and then removed because they return false). At the end all the internal variables are cleared, as in the constructor.
emasab posted a review
I've removed all the signal handlers on disable (before they were kept but ignored) and they're added again on enable. Then the overview methods are replaced with the original ones and all the internal variables are cleared.
JustPerfection rejected
Thanks! 1. Please read #1 in the previous review. If you don't null out those variables, it means they are not going to be garbage collected after disable or uninstall. 2. For timeouts, as I said in the previous review, they should be removed on destroy or disable. Search for `timeout_add` in your code, all of those timeouts should be removed (#4 in version 66).