1. You should remove the timeout in disable (extension.js line 214): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Also do this in disable: ```js CAT_LABELS = null; SIGNAUX = []; recents = []; ``` 3. Remove convenience.js since you are not using it. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

why should it be removed in the disable, instead of immediately? There isn't just one timeout here, there are one timeout PER OPENING of the extension's popup menu. Keeping track of an entire array of timeout ids until the user exits the session sounds crazy

You should remove it in disable because timeouts can get delayed and the callback can get triggered after disable. For example, it can get triggered in lock screen. btw, you don't need to use `Mainloop.source_remove(a);` in the callback (extension.js line 218). Just do this at the end of the callback: ```js a = null; return false; ```

oh ok thanks, so i would keep track of a single var a, and if it's not null when the user disables the extension then i remove it there?

Yes. We have an example here: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources