Review of "TopHat" version 1

Details Page Preview

View CPU, memory, disk, and network activity in the GNOME top bar.

Extension Homepage
https://github.com/fflewddur/tophat

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
20 Active
19 Active
18 Active
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You should also do this inside the callback function (line 57 extension.js): ```js this.addTimeout = 0; ``` 2. You forgot to remove the timeout in destroy: - line 91 lib/net.js - line 93 lib/mem.js https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 3. Why the copyright year is 2020 in some files? I'm asking that because this is the first version of the extension. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
fflewddur posted a review
Thanks so much for the prompt review! I've fixed the missing timeouts and set the source ID to 0 at the end of the callback in extension.js. The copyright is 2020 because that's when I started working on this extension and first shared it on GitHub (https://github.com/fflewddur/tophat/commits/master); let me know if that should be updated to 2022 since this would be the first public release.
JustPerfection posted a review
No issue with the copyright year. You can update them if you want. Thanks!