Review of "TopHat" version 16

Details Page Preview

View CPU, memory, disk, and network activity in the GNOME top bar.

Extension Homepage
https://github.com/fflewddur/tophat

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
20 Active
19 Active
18 Active
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't store any instance of objects in a property in the default class you are exporting (line 26 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 2. Timeout should be removed on destroy (line 149 `vitals.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)
fflewddur posted a review
Thanks for catching these issues! Regarding the first, does that apply to the extension as well, or only the preferences window?
JustPerfection posted a review
You mean there is something in `extension.js` that needs to be cleaned up on disable?