Review "Rounded Window Corners" version 1

Review of "Rounded Window Corners" version 1

Details Page Preview

Rounded Window Corners

by yilozt

Add rounded corners for all windows

Extension Homepage: https://github.com/yilozt/rounded-window-corners

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
12	Rejected
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected July 31, 2022

1. You should remove the timeout in disable (line 68 app.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. You are using hdy + gtk3 for prefs. Some users won't have hdy installed. Why aren't you using Adw Gtk4 which is included in >=40? 3. Use `ExtensionUtils.getSettings()` instead of creating custom function (line 15 utils/settings.js): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/b4e63b3a2cac4c2f6866ed430bd6fad51fd91de4/js/misc/extensionUtils.js#L211

Luo Yi posted a review July 31, 2022

I will rewrite preferences pages in Gtk4, thanks very much.