Add rounded corners for all windows
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
12 | Rejected |
11 | Active |
10 | Active |
9 | Active |
8 | Active |
7 | Active |
6 | Active |
5 | Active |
4 | Active |
3 | Rejected |
2 | Rejected |
1 | Rejected |
Timeout should be removed on destroy or disable (line 129 manager/rounded_corners_manager.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
Added timeout will been clear in line 105 of `manager/rounded_corners_manager.js` in `on_remove_effect()`, `on_remove_effect()` is called when destroy window actor: ```diff shadow.clear_effects () shadow.destroy () } + + // Remove all timeout handler + const timeout_id = actor.__rwc_rounded_window_info?.unminimized_timeout_id + if (timeout_id) GLib.source_remove (timeout_id) delete actor.__rwc_rounded_window_info } ```
Ok, but what's the reason for not using `info.unminimized_timeout_id` directly? Also in the timeout callback you should null out `info.unminimized_timeout_id` before returning `false`.