Review of "Rounded Window Corners" version 12

Details Page Preview

Add rounded corners for all windows

Extension Homepage
https://github.com/yilozt/rounded-window-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. No need to use `this.initTranslation()` (line 18 `prefs.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 2. You should `uninit_settings()` in `disable()` and window close request in `prefs.js`. ```js window.connect('close-request', () => { uninit_settings(); }); ```