Review of "Extension List" version 32

Details Page Preview

Simple GNOME Shell extension manager in the top panel For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/extension-list

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
As I mentioned in the other extension review, the `gsettings` needs to move to `buildPrefsWidget` (line 10 prefs.js): https://extensions.gnome.org/review/33520 Do you want to fix that and send it again?
grroot posted a review
Does that matter? The prefs page runs as a standalone process, and the bindings with `Gio.Settings` will be disconnected automatically when the widgets finalize. It should never crash the GNOME Shell. Right? Whatever, maybe the next time.
JustPerfection active
It doesn't crash GNOME Shell but it remains there after the prefs window is getting closed (not going to be garbage collected). I approve this since you have other extensions like this but please fix it for the next version.
grroot posted a review
Let the `gsetting` connect to log sth in the global scope, if that so, open the setting window repeatedly to modify the setting, each time the output log is only one or will increase with the number of openings?
JustPerfection posted a review
1. Do this in `buildPrefsWidget`: ```js gsettings.connect('changed::del-button', () => { log('TEST'); }); ``` 2. Restart GNOME Shell. 3. Open the prefs window and then close it. 4. Open dconf and change the `del-button` value. As you can see the log is happening in the log. Because the global object didn't get destroyed after you closed the prefs window.