Review of "Weather" version 14

Details Page Preview

A simple extension for displaying weather information from several cities in GNOME Shell

Extension Homepage
https://github.com/Neroth/gnome-shell-extension-weather

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
18 Active
17 Active
16 Inactive
15 Inactive
14 Inactive
13 Inactive
12 Inactive
11 Rejected
10 Inactive
9 Active
8 Inactive
7 Rejected
6 Inactive
5 Rejected
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active
- we try to move away from dotfiles in $HOME - GLib.get_user_cache_dir() would be a better choice for the logfile - gjs complains if a function returns a value for some code paths and none for others; this doesn't mean that every function needs a return value - *never* returning a value is perfectly fine (and preferable to meaningless "return 0"s and friends) None of the above is enough reason to reject the update though ...
Neroth posted a review
For the dotfiles in $HOME I send a fix in 5 min ;) ! For return 0; I know but it's a habit :)