GNOME Shell Extensions

Review of "Pano - Clipboard Manager" version 8

Details Page Preview

Pano - Clipboard Manager

by alperenelhan

Next-gen Clipboard manager for Gnome Shell You need libgda and gsound for this extension to work. Fedora: sudo dnf install libgda libgda-sqlite Arch Linux: sudo pacman -S libgda (libgda6 for gnome-43 or later) Ubuntu/Debian: sudo apt install gir1.2-gda-5.0 gir1.2-gsound-1.0 openSUSE: sudo zypper install libgda-6_0-sqlite typelib-1_0-Gda-6_0 typelib-1_0-GSound-1_0

Extension Homepage
https://github.com/oae/gnome-shell-pano
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
22 Active
21 Rejected
20 Rejected
19 Active
18 Active
17 Active
16 Active
15 Active
14 Rejected
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
You should remove the timeout in disable (line 207 extension.js)?
alperenelhan waiting for author
It is being removed. Both using the `return SOURCE_REMOVE` and Source.remove(sourceId) (line 203, 206). This is how debounce works. If you have some suggestion to change this, I am happy to do it.
JustPerfection rejected
As we stated in the review guidelines: > You MUST remove all active main loop sources in disable(), even if the callback function will eventually return false or GLib.SOURCE_REMOVE. https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources and line 206 isn't enough because of the next line. You can keep all the timeout source ids in an array and remove all of them in disable.