Review of "Pano - Clipboard Manager" version 20

Details Page Preview

Next-gen Clipboard manager for Gnome Shell You need libgda and gsound for this extension to work. Fedora: sudo dnf install libgda libgda-sqlite Arch Linux: sudo pacman -S libgda (libgda6 for gnome-43 or later) Ubuntu/Debian: sudo apt install gir1.2-gda-5.0 gir1.2-gsound-1.0 openSUSE: sudo zypper install libgda-6_0-sqlite typelib-1_0-Gda-6_0 typelib-1_0-GSound-1_0

Extension Homepage
https://github.com/oae/gnome-shell-pano

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
22 Active
21 Rejected
20 Rejected
19 Active
18 Active
17 Active
16 Active
15 Active
14 Rejected
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `init()` method (line 1238 prefs.js). Not needed. 2. You are doing too much in the constructor of the default class you are exporting (line 3279 extension.js): That is breaking three ego rules: - https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources - https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects - https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals Please move them to enable and null those out/ destroy / disconnect signals in disable. 3. `isEnabled` is a bad practice (line 3348 extension.js). You really don't need it to check something like line 3315, 3300 and 3429. 4. Please remove the import versions. 5. Don't use `var`. Use `let` and `const` instead. 6. Extensions cannot use `run_dispose()` (line 252 and 405 extension.js): > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose 7. Please use `TextDecoder` instead of `byteArray` (line 222 extension.js): https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder
alperenelhan posted a review
Thank you for the review, I will update the code