Review of "Pushover Message Notifications" version 3

Details Page Preview

Displays Pushover Notifications within GNOME and within your tray. Privacy respecting unofficial client.

Extension Homepage
https://github.com/cwittenberg/gnome-pushover-messages-unofficial

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Inactive
6 Inactive
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Do this instead of line 43 extension.js, line 33 preferences/aboutPage.js, line 41 preferences/generalPage.js: ```js const thisExtensionDir = Me.path; ``` 2. What is the reason for line 46-57 (extension.js)? 3. Use `ExtensionUtils.getSettings()` instead (line 33 lib/api.js, line 42 prefs.js). 4. You cannot create objects in global scope (line 44 preferences/generalPage.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 5. Why are you using the enum there while not using it (line 4 schemas/org.gnome.shell.extensions.pushover.gschema.xml)? If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions