Review of "Pushover Message Notifications" version 5

Details Page Preview

Displays Pushover Notifications within GNOME and within your tray. Privacy respecting unofficial client.

Extension Homepage
https://github.com/cwittenberg/gnome-pushover-messages-unofficial

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Inactive
6 Inactive
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

cwittenberg posted a review
I did notice i was loading pushoverAPI object immediately whenever generalPage.js is loaded when prefs.js: fillPreferencesWindow is invoked, which is indeed not per guidelines. Have adjusted.
JustPerfection rejected
Still creating it as global, not local. The thing is, when the window is closed, that global variable won't get garbage collected. To fix that: - Just make it local (if you are not accessing `pushoverAPI` from out side of the module) or; - Use dependency injection for `GeneralPage`. btw, there are some unnecessary comments in the code that needs to be removed too. Log should be only available on debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging