Good but #4 from version 3 review hasn't been addressed here.

Thanks for your thorough review, very helpful. I have made amends as you requested. In response: 1. Do this instead of line 43 extension.js, line 33 preferences/aboutPage.js, line 41 preferences/generalPage.js: ```js const thisExtensionDir = Me.path; ``` Christian: fixed 2. What is the reason for line 46-57 (extension.js)? Christian: you are right, unnecessary. 3. Use `ExtensionUtils.getSettings()` instead (line 33 lib/api.js, line 42 prefs.js). Christian: i didn't know this! much cleaner, thanks. 4. You cannot create objects in global scope (line 44 preferences/generalPage.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Christian: my bad. I have moved initiation of API class and pages out of global scope. 5. Why are you using the enum there while not using it (line 4 schemas/org.gnome.shell.extensions.pushover.gschema.xml)? Christian: removed it.

Actually, i did? Have a look at how I call GeneralPage object, its moved out of global scope now - prefs.js line 43. Object is only instantiated after fillPreferencesWindow is triggered, not in global scope? Please do let me know if you see it differently / have other guidance I might have missed. Cheers, Christian.

Answered in version 5 review.