Review of "Activities Icon & Label" version 1

Details Page Preview

Add an icon to the Activities button. based on GNOME gnome-shell and RHEL gnome-shell patch

Extension Homepage
https://github.com/howbea/enhunce-activites

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. `this._xdndTimeOut` doesn't exist in that class (line 154 extension.js). Just remove the source id in the same object (`ActivitiesIndicator`) on destroy. 2. The way you are disconnecting is not the right way (line 142 and 148 extension.js). Give signal id to line 60 and 64. Disconnect them in the same object (`ActivitiesIndicator`) on destroy. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
btw, we have examples in review guidelines page: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources