Review of "Activities Icon & Label" version 2

Details Page Preview

Add an icon to the Activities button. based on GNOME gnome-shell and RHEL gnome-shell patch

Extension Homepage
https://github.com/howbea/enhunce-activites

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Still has the same issues and you duplicated what you had in `ActivitiesIndicator` class. To fix that: 1. Remove line 149-161, 165-177. 2. Change line 62 to `this._showingSignal = Main.overview.connect('showing', () => {` 3. Change line 67 to `this._hidingSignal = Main.overview.connect('hiding', () => {` 4. Add this to the `ActivitiesIndicator` class: ```js _onDestroy() { if (this._showingSignal) { Main.overview.disconnect(this._showingSignal); this._showingSignal = null; } if (this._hidingSignal) { Main.overview.disconnect(this._hidingSignal); this._hidingSignal = null; } if (this._xdndTimeOut) { GLib.Source.remove(this._xdndTimeOut); this._xdndTimeOut = null; } super.destroy(); } ``` btw, use of `actor` is deprecated in line 47. Use `this.add_actor(box);` instead.